Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[configure-splash-screen] Use proper bin paths to files #2840

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

byCedric
Copy link
Member

I noticed these weren't matching after I linked it with yarn link. Maybe we should include this folder in the yarn workspace so installs are easier?

@brentvatne
Copy link
Member

Maybe we should include this folder in the yarn workspace so installs are easier?

i tried to explain the motivation for it living in the unlinked-packages directory in the readme in that directory:

unlinked-packages

Packages in this directory are published independently of other packages in the repository and should not be symlinked in development. They may be depended on by packages in packages/ but should be consciously and carefully versioned. It's likely that libraries here should be moved somewhere else or need to be fundamentally re-designed, eg: configure-splash-screen lives here because it only supports one very specific version of expo-splash-screen at any given time, but it should probably support multiple versions of expo-splash-screen.

The publish script used for packages will not publish packages from this directory. They should be published manually when needed, and updates to other libraries that depend on them should be updated manually.


let me know if you have any questions about that. it's certainly not ideal, just the state of the world today

@brentvatne brentvatne merged commit 046f5b4 into master Nov 5, 2020
@brentvatne brentvatne deleted the @bycedric/fix/configure-splash-screen-bin-path branch November 5, 2020 01:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants